email_subject*: don't fail if SPIDERMON_EMAIL_SUBJECT_TEMPLATE is configured in favor of SPIDERMON_EMAIL_SUBJECT #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow usage of SPIDERMON_EMAIL_SUBJECT_TEMPLATE over SPIDERMON_EMAIL_SUBJECT. If the latter is configured it still has precedence.
Gallaecio
requested changes
May 3, 2019
Gallaecio
approved these changes
May 3, 2019
|
👍 by me. I must say I’m surprised it passes all checks, though 🙂 . I think Spidermon uses Black, and Black’s line length limit is 88. |
|
I played around with line length a bit, seems it makes no difference to black. I reformatted the message regardless. |
|
I know that we don't have tests for the actions (and it is something we need to improve), so would you mind create in this PR a new test file for this action and add some tests to make sure that the lack of one of the subject arguments raise an exception? Other tests for other arguments may be created after that (I don't want a PR handles more than one feature). |
|
No problem, will be some time before I get a shot at this though. |
|
@Toritrae , would you be able to include the tests for your code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow usage of SPIDERMON_EMAIL_SUBJECT_TEMPLATE instead of SPIDERMON_EMAIL_SUBJECT without failing during initialization. If EMAIL_SUBJECT is configured it still has precedence.