Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Documenting built-in mixins #232

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

docs: Documenting built-in mixins #232

wants to merge 12 commits into from

Conversation

rennerocha
Copy link
Collaborator

Continue work started on #133

@rennerocha rennerocha added this to the 1.12.0 milestone Nov 26, 2019
@rennerocha rennerocha changed the title Mixins docs docs: Documenting built-in mixins Nov 27, 2019
@dariuschira
Copy link

Hey @rennerocha I've looking a bit into #133 and this and was wondering if the issue could be up for grabs?

I think documenting SpiderMonitorMixin should include some docs for spidermon.contrib.stats.counters.DictPercentCounter which is mixed with ResponseInfo from mixin class.

I'd be happy to contribute some docs to this.

@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   69.28%   69.28%           
=======================================
  Files          67       67           
  Lines        2745     2745           
  Branches      306      306           
=======================================
  Hits         1902     1902           
  Misses        784      784           
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0623843...811d86c. Read the comment docs.

@rennerocha rennerocha removed this from the 1.12.0 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants