Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ItemAdapter.ADAPTER_CLASSES an Iterable instead of a deque #74

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Jul 5, 2023

Closes #71

Includes #73, otherwise tests fail.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #74 (05fb254) into master (bff7a0c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 05fb254 differs from pull request most recent head b30b6a9. Consider uploading reports for the commit b30b6a9 to get more accurate results

@@            Coverage Diff            @@
##            master       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          306       306           
=========================================
  Hits           306       306           
Impacted Files Coverage Δ
itemadapter/adapter.py 100.00% <100.00%> (ø)

@kmike kmike merged commit 0b65bf3 into master Jul 6, 2023
28 checks passed
@kmike
Copy link
Member

kmike commented Jul 6, 2023

Thanks @elacuesta!

@elacuesta elacuesta deleted the remove-deque-type-hint branch July 7, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ItemAdapter.ADAPTER_CLASSES a list instead of deque
4 participants