Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eslint-config-scratch to GithubActions #141

Merged
merged 6 commits into from
Sep 28, 2023

Conversation

delasare
Copy link
Contributor

@delasare delasare requested review from a team, colbygk and cwillisf and removed request for a team and colbygk September 28, 2023 17:09
Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, glad it was so straight forward!
I think you'll need a couple changes to make the release work, but the rest looks good

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
@cwillisf
Copy link
Contributor

cwillisf commented Sep 28, 2023

Actually, on second thought, it might be good to have this workflow run on branches & PRs as well. It'll just amount to setup and npm test since semantic-release will notice it's on a non-deploy branch and do nothing. That seems good for verifying work before merging it.

@delasare
Copy link
Contributor Author

I add a 'is master' conditional to the semantic release step

Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delasare delasare merged commit 93a13c4 into master Sep 28, 2023
1 check passed
Copy link

🎉 This PR is included in version 9.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants