-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move eslint-config-scratch to GithubActions #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, glad it was so straight forward!
I think you'll need a couple changes to make the release work, but the rest looks good
Actually, on second thought, it might be good to have this workflow run on branches & PRs as well. It'll just amount to setup and |
I add a 'is master' conditional to the semantic release step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🎉 This PR is included in version 9.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves
https://scratchfoundation.atlassian.net/browse/ENG-32