Remove all audio effects except pitch and pan #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulkaplan
approved these changes
Jun 19, 2017
|
Who knows; this could be reimplemented in a (user-made) extension! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
To address performance issues that cause the audio to drop out (as discussed here and here), we are removing the echo, reverb, fuzz and robot effects.
Depends on this PR in scratch-blocks and this PR in scratch-vm.
Proposed Changes
Remove the echo, reverb, fuzz, and robot effects.
Reason for Changes
These effects create large numbers of webaudio nodes, which contributes to audio glitches.