Skip to content

Handle subpixel viewboxes for SVG skins #90

Handle subpixel viewboxes for SVG skins

Handle subpixel viewboxes for SVG skins #90

Triggered via pull request February 21, 2024 07:49
Status Failure
Total duration 20s
Artifacts

commitlint.yml

on: pull_request
commitlint
10s
commitlint
Fit to window
Zoom out
Zoom in

Annotations

1 error
commitlint
You have commit messages with errors ⧗ input: Change minimum SVG mipmap level to 3 ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Give skins a "native" & "quad" size and center Skins' "native size" is the size that their bounds are supposed to be. Their "quad size" is the size the quadrilateral is really rendered at. ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Use subpixel-adjusted center+size for SVG skins ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Remove createMIP zero-size checks _setSubpixelViewbox ensures nonzero image dimensions at all rendered scales. ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Handle empty SVG skins' rotation centers ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Use "logical bounds" for distortion effect coords ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: calculate drawables' AABBs from "native" bounds ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Document new rectangle AABB algorithm ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Remove Rectangle.initFromModelMatrix ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Remove debugging bounds around rendered sprites ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Do CPU-side effect transforms in "logical space" ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Only apply CPU mosaic+pixelate in "logical bounds" ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Make _calculateRotationCenter private... and just return nativeRotationCenter in getSkinRotationCenter to do so. ✖ subject may not be empty [subject-empty] ✖ subject may not end with full stop [subject-full-stop] ✖ type may not be empty [type-empty] ⚠ body must have leading blank line [body-leading-blank] ✖ found 3 problems, 1 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Reflow text bubble lines non-lazily This was a case of premature optimization that needs to go for the next commit's optimization to work. ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems