feat(3266): add scope and scopeId to banner models #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar1312
requested changes
Jan 17, 2025
models/banner.js
Outdated
| .positive() | ||
| .description('Identifier to pipelineId for PIPELINE, buildId for BUILD, or null for GLOBAL') | ||
| .optional() | ||
| .allow(null) |
There was a problem hiding this comment.
We should make this non nullable when the scope is PIPELINE or BUILD
| }, | ||
| { transaction } | ||
| ); | ||
| await queryInterface.addColumn( |
There was a problem hiding this comment.
should we index by scope and scope id for faster look up?
Co-authored-by: Dayanand Sagar <[email protected]>
Co-authored-by: Dayanand Sagar <[email protected]>
pritamstyz4ever
previously approved these changes
Jan 21, 2025
sagar1312
requested changes
Jan 21, 2025
| @@ -81,7 +105,7 @@ module.exports = { | |||
| * @property keys | |||
| * @type {Array} | |||
| */ | |||
| keys: ['message', 'type', 'createTime'], | |||
| keys: ['message', 'type', 'createTime', 'scope', 'scopeId'], | |||
There was a problem hiding this comment.
Also add a composite index having scope and scopeId
indexes: [{ fields: ['isActive'] }, { fields: ['scope', 'scopeId'] }]
Co-authored-by: Dayanand Sagar <[email protected]>
sagar1312
approved these changes
Jan 21, 2025
|
🎉 This PR is included in version 24.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current implementation of banner schema is at the global level.
Objective
Sometimes banner is needed at the pipeline or build level only.
References
screwdriver-cd/screwdriver#3266
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.