fix(2981): remote join wait on downsream jobs during restart #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-oksaku
reviewed
Aug 27, 2024
Co-authored-by: y-oksaku <[email protected]>
y-oksaku
reviewed
Aug 27, 2024
y-oksaku
approved these changes
Aug 28, 2024
|
All fixes have been done.
|
tkyi
reviewed
Aug 29, 2024
plugins/builds/triggers/helpers.js
Outdated
| * @param {String} [startNode] Starting/trigger node | ||
| * @returns {Array<String>} subsequent job names | ||
| */ | ||
| function subsequentJobFilter(workflowGraph, startNode) { |
There was a problem hiding this comment.
I don't feel strongly but would something like getDownstreamJobs or getSubsequentJobs be more clear?
There was a problem hiding this comment.
@tkyi
Thanks for your comment.
Renamed to"getSubsequentJobs" because it is used not only for dosntream but also for normal events.
tkyi
reviewed
Aug 29, 2024
tkyi
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
fix #2981
When an upstream job of the remote-join job is restarted, remote-join job immediately runs reusing build status from previous event.
Objective
When a remote join job's upstream jobs are restarted, the remote join job will use the post-restart build status as the trigger for jobs that may run from the restart job.
Enumerate jobs started after the restart job, referring to the subgraph filter in the UI, and do not use the recent build status of the group event.
We found another bug related to remote join while working on this. (Remote join jobs are not triggered correctly on restart #3177)
Therefore, a test has been added to the “Tests for behavior not ideal” section
Also, with this fix, the test that was originally in “Tests for behavior not ideal” works as expected so that it will be removed and the test that was xit will be executed.
References
#2981
#3177
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.