feat(3266): fixed unit tests for banner

package.json

@@ -7,6 +7,7 @@
     "pretest": "eslint . --quiet",
     "test": "nyc --report-dir ./artifacts/coverage --reporter=lcov mocha --reporter mocha-multi-reporters --reporter-options configFile=./mocha.config.json --recursive --timeout 10000 --retries 1 --exit --allow-uncaught true --color true",
     "test-debug": "mocha --inspect-brk ./test/**/*.js",
+    "test-banner": "mocha ./test/plugins/banner.test.js",
     "start": "./bin/server",
     "debug": "node --nolazy ./bin/server",
     "profile": "node --prof ./bin/server",
@@ -109,7 +110,7 @@
     "screwdriver-config-parser": "^11.0.0",
     "screwdriver-coverage-bookend": "^2.0.0",
     "screwdriver-coverage-sonar": "^4.1.1",
-    "screwdriver-data-schema": "^24.1.0",
+    "screwdriver-data-schema": "^24.2.0",
     "screwdriver-datastore-sequelize": "^9.0.0",
     "screwdriver-executor-base": "^10.0.0",
     "screwdriver-executor-docker": "^7.0.0",
@@ -118,7 +119,7 @@
     "screwdriver-executor-queue": "^5.0.0",
     "screwdriver-executor-router": "^4.0.0",
     "screwdriver-logger": "^2.0.0",
-    "screwdriver-models": "^31.0.0",
+    "screwdriver-models": "^31.1.0",
     "screwdriver-notifications-email": "^4.0.0",
     "screwdriver-notifications-slack": "^6.0.0",
     "screwdriver-request": "^2.0.1",

test/plugins/banner.test.js

@@ -104,6 +104,7 @@ describe('banner plugin test', () => {
         const message = 'Test banner example';
         const isActive = true;
         const type = 'info';
+        const scope = 'GLOBAL';
 
         beforeEach(() => {
             options = {
@@ -112,7 +113,8 @@ describe('banner plugin test', () => {
                 payload: {
                     message,
                     isActive,
-                    type
+                    type,
+                    scope
                 },
                 auth: {
                     credentials: {

test/plugins/builds.triggers.helpers.test.js

@@ -0,0 +1,85 @@
+const { assert } = require('chai');
+const { getSubsequentJobs } = require('../../plugins/builds/triggers/helpers');
+
+('use strict');
+
+describe('getSubsequentJobs', () => {
+    it('should return an empty array if startNode is not provided', () => {
+        const workflowGraph = {
+            nodes: [{ name: 'job1' }, { name: 'job2' }],
+            edges: [{ src: 'job1', dest: 'job2' }]
+        };
+
+        const result = getSubsequentJobs(workflowGraph);
+
+        assert.deepEqual(result, []);
+    });
+
+    it('should return an empty array if nodes are empty', () => {
+        const workflowGraph = {
+            nodes: [],
+            edges: [{ src: 'job1', dest: 'job2' }]
+        };
+
+        const result = getSubsequentJobs(workflowGraph, 'job1');
+
+        assert.deepEqual(result, []);
+    });
+
+    it('should return subsequent jobs correctly', () => {
+        const workflowGraph = {
+            nodes: [{ name: 'job1' }, { name: 'job2' }, { name: 'job3' }],
+            edges: [
+                { src: 'job1', dest: 'job2' },
+                { src: 'job2', dest: 'job3' }
+            ]
+        };
+
+        const result = getSubsequentJobs(workflowGraph, 'job1');
+
+        assert.deepEqual(result, ['job2', 'job3']);
+    });
+
+    it('should handle circular dependencies gracefully', () => {
+        const workflowGraph = {
+            nodes: [{ name: 'job1' }, { name: 'job2' }, { name: 'job3' }],
+            edges: [
+                { src: 'job1', dest: 'job2' },
+                { src: 'job2', dest: 'job3' },
+                { src: 'job3', dest: 'job1' }
+            ]
+        };
+
+        const result = getSubsequentJobs(workflowGraph, 'job1');
+
+        assert.deepEqual(result, ['job2', 'job3']);
+    });
+
+    it('should handle jobs with tildes correctly', () => {
+        const workflowGraph = {
+            nodes: [{ name: '~job1' }, { name: 'job2' }, { name: 'job3' }],
+            edges: [
+                { src: '~job1', dest: 'job2' },
+                { src: 'job2', dest: 'job3' }
+            ]
+        };
+
+        const result = getSubsequentJobs(workflowGraph, '~job1');
+
+        assert.deepEqual(result, ['job2', 'job3']);
+    });
+
+    it('should handle jobs with different start tildes correctly', () => {
+        const workflowGraph = {
+            nodes: [{ name: 'job1' }, { name: '~job2' }, { name: 'job3' }],
+            edges: [
+                { src: 'job1', dest: '~job2' },
+                { src: '~job2', dest: 'job3' }
+            ]
+        };
+
+        const result = getSubsequentJobs(workflowGraph, 'job1');
+
+        assert.deepEqual(result, ['~job2', 'job3']);
+    });
+});

test/plugins/data/banner.json

@@ -3,6 +3,8 @@
     "message": "Test banner example",
     "isActive": true,
     "type": "info",
+    "scope": "GLOBAL",
+    "scopeId": null,
     "createdBy": "jimgrund",
     "createTime": "2017-01-06T01:49:50.384359267Z"
 }

test/plugins/data/banners-active.json

@@ -4,6 +4,8 @@
         "message": "Test banner example",
         "type": "info",
         "isActive": true,
+        "scope": "GLOBAL",
+        "scopeId": null,
         "createdBy": "batman123",
         "createTime": "2017-01-06T01:49:50.384359267Z"
     }

test/plugins/data/banners.json

@@ -4,6 +4,8 @@
         "message": "Test banner example",
         "type": "info",
         "isActive": true,
+        "scope": "GLOBAL",
+        "scopeId": null,
         "createdBy": "batman123",
         "createTime": "2017-01-06T01:49:50.384359267Z"
     },
@@ -12,6 +14,8 @@
         "message": "Test banner example again",
         "type": "info",
         "isActive": false,
+        "scope": "GLOBAL",
+        "scopeId": null,
         "createdBy": "batman123",
         "createTime": "2017-01-07T01:49:50.384359267Z"
     },
@@ -20,6 +24,8 @@
         "message": "Test banner example yet again",
         "type": "warn",
         "isActive": false,
+        "scope": "GLOBAL",
+        "scopeId": null,
         "createdBy": "batman123",
         "createTime": "2017-01-08T01:49:50.384359267Z"
     }