feat(3266): add authn for banner list and get endpoints #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar1312
requested changes
Feb 5, 2025
Co-authored-by: Dayanand Sagar <[email protected]>
Co-authored-by: Dayanand Sagar <[email protected]>
sagar1312
requested changes
Feb 6, 2025
plugins/banners/get.js
Outdated
| @@ -13,6 +13,10 @@ module.exports = () => ({ | |||
| description: 'Get a single banner', | |||
| notes: 'Return a banner record', | |||
| tags: ['api', 'banners'], | |||
| auth: { | |||
| strategies: ['token'], | |||
| scope: ['user'] | |||
There was a problem hiding this comment.
Banners with GLOBAL scope are currently being fetched without the user being authenticated.
This change makes it backward incompatible. We are unable fetch 'GLOBAL' banners when the user is not authenticated.
Auth check may need to be done selectively based on the scope. GLOBAL can be accessed by anyone like before. But, PIPELINE should be accessed by a user with valid token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current banner endpoints for list and get do not require user authentication, which is unintended behavior.
Objective
The change aims to enforce token-based authentication for both API endpoints.
References
#3266
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.