feat: New confirm action modal UI #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adong
approved these changes
Jun 28, 2024
adong
reviewed
Jun 28, 2024
| * @returns {string} | ||
| */ | ||
| export function capitalizeFirstLetter(string) { | ||
| return string.charAt(0).toUpperCase() + string.slice(1); |
There was a problem hiding this comment.
can we have a default string = '' ?
There was a problem hiding this comment.
It already returns '' if the input string is empty.
adong
reviewed
Jun 28, 2024
| return flattenParameters(event.meta.parameters); | ||
| } | ||
|
|
||
| return undefined; |
There was a problem hiding this comment.
It intentionally returns undefined, rather than {}. Either one should be fine, and I'm curious to know the reason for that.
There was a problem hiding this comment.
Mainly to keep things in line with the original API response. The meta field returned on the event from the API would resolve to undefined if there are no parameters set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
New UI for the modal to confirm start/restarting of a job from the workflow graph.
Objective
As part of the new UI work, this provides a new modal that is a Glimmer component and leverages the pipeline parameters component from #1068.
The new component also properly displays the desired action that is to be taken with the job (e.g., start or restarting a job)
References
screwdriver-cd/screwdriver#3200
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.