Merge pull request #230 from Linfye/fix-long-parameter-list

Fix Long Parameter List
scribe-org · Oct 28, 2024 · 0bf3879 · 0bf3879
2 parents 7ead6c1 + 44898ea
commit 0bf3879
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/app/src/main/java/be/scri/helpers/DatabaseHelper.kt b/app/src/main/java/be/scri/helpers/DatabaseHelper.kt
@@ -15,13 +15,15 @@ class DatabaseHelper(
     }
 
     override fun onCreate(db: SQLiteDatabase) {
+        // No operation for now
     }
 
     override fun onUpgrade(
         db: SQLiteDatabase,
         oldVersion: Int,
         newVersion: Int,
     ) {
+        // No operation for now
     }
 
     fun loadDatabase(language: String) {

diff --git a/app/src/main/java/be/scri/helpers/RatingHelper.kt b/app/src/main/java/be/scri/helpers/RatingHelper.kt
@@ -4,6 +4,7 @@ import android.content.Context
 import android.content.Intent
 import android.content.pm.PackageManager
 import android.net.Uri
+import android.util.Log
 import android.widget.Toast
 import be.scri.activities.MainActivity
 import com.google.android.play.core.review.ReviewManagerFactory
@@ -15,6 +16,7 @@ class RatingHelper {
                 val packageManager = context.packageManager
                 packageManager.getInstallerPackageName(context.packageName)
             } catch (e: PackageManager.NameNotFoundException) {
+                Log.e("RatingHelper", "Failed to get install source", e)
                 null
             }
 

diff --git a/detekt.yml b/detekt.yml
@@ -6,7 +6,7 @@ style:
     LoopWithTooManyJumpStatements:
         active: false
     WildcardImport:
-        active: false
+        active: true
     ReturnCount:
         active: false
     UnusedPrivateProperty:
@@ -24,23 +24,23 @@ complexity:
     ComplexCondition:
         active: true
     LongParameterList:
-        active: false
+        active: true
     LongMethod:
         active: true
     CyclomaticComplexMethod:
         active: false
 
 exceptions:
     SwallowedException:
-        active: false
+        active: true
     InstanceOfCheckForException:
-        active: false
+        active: true
 
 empty-blocks:
     EmptyCatchBlock:
         active: true
     EmptyFunctionBlock:
-        active: false
+        active: true
 
 performance:
     SpreadOperator: