Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate Scribe needs an action #165

Closed
2 tasks done
angrezichatterbox opened this issue Oct 2, 2024 · 5 comments
Closed
2 tasks done

Rate Scribe needs an action #165

angrezichatterbox opened this issue Oct 2, 2024 · 5 comments
Assignees
@henrikth93
Labels
feature New feature or request good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@angrezichatterbox
Copy link
Member

angrezichatterbox commented Oct 2, 2024 •
edited
Loading

Terms

Description

The Rate Scribe Option in the About Page currently doesn't have an action. The option has been implemented to be rated in either F-Droid or in the Google Play store depending on where it is being installed from.

Contribution

I would love to work on this and am more than willing to help anyone solve this issue.
@angrezichatterbox angrezichatterbox added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest Included as a part of Hacktoberfest labels Oct 2, 2024
@henrikth93 henrikth93 self-assigned this Oct 10, 2024
@MostafaMohamed2002
Copy link
Contributor

can we do it before you upload the app to playstore ??

@angrezichatterbox
Copy link
Member Author

I am not sure about F-Droid. We could create the function for it as we can use the app identifier for the Play Store URL that would not change on the app release. I am not about how it would function before release.

@henrikth93
Copy link
Member

I have done some on this. Gonna contact you later @angrezichatterbox

@andrewtavis
Copy link
Member

Ya for this maybe we can comment out the code for the the actual Play store and F-Droid actions and leave the toast for now, but still have the code that we need once we have the URLs :)

@henrikth93 henrikth93 mentioned this issue Oct 11, 2024
Merged
@andrewtavis
Copy link
Member

I guess we can close for now and do another issue later when we have the URLs :) Closed in #187. Thanks @henrikth93!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrikth93 henrikth93

Labels
feature New feature or request good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Scribe Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andrewtavis @MostafaMohamed2002 @angrezichatterbox @henrikth93