-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action for "rate scribe" #187
Add action for "rate scribe" #187
Conversation
This commit will add an action for "rate scribe"
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Commented out the variable for installsource
Comment out unused function, which will later be used.
Remove blank line
Fixed multiline issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, @henrikth93. This is one method to do it and is ideal since we also have F-droid. Also, I don't think we need to comment on those lines, as the statements already handle show no installation source when not installed from F-droid or Play Store.
However, for the Play Store, an ideal method would be to use the Play Store API. It has an advantage. It would show a dialogue for rating once the app is on the Play Store, and for now, when used, the review would always return successfull.
Fixing linting errors
This commit will add functionality that enables us to access the google play store directly when rating the app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me now :) Thanks @henrikth93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful stuff, @henrikth93, and thanks for the review and directing, @angrezichatterbox! 🚀🚀
This commit will add an action for "rate scribe"
Contributor checklist
Description
Related issue