Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic UI for command key functionality #101

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

  • The PR adds functionality for changing the UI of the toolbar of the keyboard for different states. Currently, it has idle state select command state, Translate, conjugate and plural states being used.

Related issue

Copy link

github-actions bot commented Sep 10, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Sep 10, 2024

Could we run a command during the build that would fix all linting issues that could be auto-fixed?

Also are there any strings for Translate, Conjugate, Plural ?

@andrewtavis
Copy link
Member

andrewtavis commented Sep 10, 2024

Hey @angrezichatterbox 👋 I've added auto-fixing the linting errors as a topic for the next dev sync :) Historically I haven't done this on projects as I'd like to fix them and learn what the problems were, and we should set up an auto formatting workflow for contributors where the code is formatted correctly on save. Do we want to make an issue for Android Studio settings and then add them to the documentation?

And there are no strings for the commands as those have historically been hard coded into the files themselves. This can also be discussed in the sync! Localization just wasn't a thing at the start :)

I'll get to the review this evening :)

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Sep 10, 2024

Hey @angrezichatterbox 👋 I've added auto-fixing the linting errors as a topic for the next dev sync :) Historically I haven't done this on projects as I'd like to fix them and learn what the problems were, and we should set up an auto formatting workflow for contributors where the code is formatted correctly on save. Do we want to make an issue for Android Studio settings and then add them to the documentation?

And there are no strings for the commands as those have historically been hard coded into the files themselves. This can also be discussed in the sync! Localization just wasn't a thing at the start :)

I'll get to the review this evening :)

Since we have already set up ktlint, we could do basic formatting of lines or unnecessary spaces using ktlint itself so that at least some of the possible linting issues can be removed when the build is done. It just came across my mind since it's already registered in our gradle tasks while adding ktlint.

For now, I have hardcoded them in a single language across all the keyboards.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, @angrezichatterbox! First major update to the keyboard 😊 Thanks so much for the continued work here :) We're making so much progress!

@andrewtavis andrewtavis merged commit 8231db4 into scribe-org:main Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants