Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference all strings from scribe i18n #106

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

  • The pull request adds the leftover strings from i18n to the app.
  • It also corrects some layout issues in some pages which I could notice.

Related issue

5701774 Add missing and update incorrect strings

git-subtree-dir: app/src/main/assets/i18n
git-subtree-split: 5701774cc4f4cd7665d86eb264a176c9627b95d9
Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @angrezichatterbox! We'll be able to bring in the other strings for other languages and any other corrections that may be on the way! So great that localization is supported so early in the process 😊

@andrewtavis andrewtavis merged commit e2c413d into scribe-org:main Sep 13, 2024
1 check passed
@angrezichatterbox
Copy link
Member Author

Awesome work, @angrezichatterbox! We'll be able to bring in the other strings for other languages and any other corrections that may be on the way! So great that localization is supported so early in the process 😊

Could we start working on the keyboard issues? I would love to get to know the keyboard codebase much more.

I also have some more detekt issues which I will be making today. It's the festive season here so I got a little busy.

@andrewtavis
Copy link
Member

Sounds good, @angrezichatterbox! I can make some more issues for the keyboard soon :)

@andrewtavis
Copy link
Member

Tons of new issues just made, @angrezichatterbox! Many of the new ones are for the keyboard as well :) Let me know what sounds appealing, and I've also already pinged you in the ones I think would be good to look into first 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants