Refactor RecyclerView item decoration in AboutFragment and SettingsFr…

[MostafaMohamed2002]

…agment

• Extracted the custom RecyclerView item decoration logic into a separate class called CustomDividerItemDecoration.
• Added the CustomDividerItemDecoration to the RecyclerViews in AboutFragment and SettingsFragment.
• Applied a custom drawable as the divider with a width of 1dp and rounded corners.
• Set the left and right margins of the dividers to 50dp.

Fixes #139

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

Related issue

#139

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo

• The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[MostafaMohamed2002]

do i have a permission to resolve conflicts ?

[andrewtavis]

You should be able to merge main into your branch in your IDE and then resolve them locally, @MostafaMohamed2002 :)

[andrewtavis]

Another quick thing here, @MostafaMohamed2002: On a Pixel 8 Pro emulator the lines between the languages in settings seem to be button outlines:

Could we get that to just be an individual line and not having the sides as well?

[MostafaMohamed2002]

I'll check on it and fix it 😃

[andrewtavis]

Thanks, @MostafaMohamed2002!

[MostafaMohamed2002]

[andrewtavis]

Nice, looking great! Do you want to fix the merge conflict and I'll bring it in? :)

[MostafaMohamed2002]

thanks , but i need to take alook at language settings fragment 😊
soon i'll ask for merge .

[MostafaMohamed2002]

it's ready to merge , you can have a final look if it's necessary 😊

[MostafaMohamed2002]

when resolving the conflict i should choose the right and left side , i accepted the left only 😂

[andrewtavis]

So i should add import CustomDividerItemDecoration, @MostafaMohamed2002?

[MostafaMohamed2002]

So i should add import CustomDividerItemDecoration, @MostafaMohamed2002?

No it's all ok now 👌

[andrewtavis]

Looking great, @MostafaMohamed2002! 😊 Really appreciate your continued support for the project 🚀