Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining and pulling members up to the superclass. #216

Merged

Conversation

growabeard
Copy link
Contributor

Contributor checklist


Description

This PR is fixing the detekt issue TooManyFunctions for the various language KeyboardIME classes.
Disclaimer: yes I know this is pulling up functions to the parent class which already violates the detekt issues. However, I think there is something to be gained in clearing up duplicate code.

To test: turn off the detekt TooManyFunctions issue and run ./gradlew detekt and observe the output on main branch.

Related issue

Copy link

github-actions bot commented Oct 21, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis requested review from angrezichatterbox and andrewtavis and removed request for angrezichatterbox October 21, 2024 10:34
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 21, 2024
@andrewtavis
Copy link
Member

andrewtavis commented Oct 21, 2024

Checking on this, @growabeard: We could close #203 after this as this solves the same issue?

@growabeard
Copy link
Contributor Author

growabeard commented Oct 21, 2024

There are 3 more classes from 203 I want to use as reference for a new PR for this issue. I can close 203 though, it was too big and I wanted to split up the work.

@andrewtavis
Copy link
Member

Sounds good, @growabeard, and I do definitely agree that we should try to centralize as much of this code as possible seeing as how the number of keyboards will increase over time :)

@andrewtavis
Copy link
Member

Are we ready for a review here, @growabeard? :)

@growabeard
Copy link
Contributor Author

Are we ready for a review here, @growabeard? :)

Please do!

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work @growabeard. The change you have made is very important as the project moves forward as it helps to avoid the boilerplate code that was present in each class. Thank you!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really amazing work, @growabeard 😊 Thanks so much for the focus you put into simplifying the project down. This will make expanding the project a so much easier post release 🚀

@andrewtavis andrewtavis merged commit a25f8d4 into scribe-org:main Oct 22, 2024
2 checks passed
@growabeard growabeard deleted the fix-toomanyfunctions-keyboards branch October 28, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants