Fix Magic Number Issues #234
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
| @@ -62,6 +61,9 @@ abstract class SimpleKeyboardIME( | |||
| private var emojiBtnTablet2: Button? = null | |||
| private var emojiSpaceTablet2: View? = null | |||
| private var emojiBtnTablet3: Button? = null | |||
|
|
|||
| // how quickly do we have to doubletap shift to enable permanent caps lock | |||
There was a problem hiding this comment.
For comments that are their own line, @Linfye, can we capitalize the first letter and put a period at the end as they should be complete sentences? In the future :) I'll fix this!
There was a problem hiding this comment.
And also you were copying it over, so no stress, just for next time 😊
There was a problem hiding this comment.
Updated the comments in the project to also follow the style discussed above. Thanks for the fixes here, @Linfye!
|
We're really making some great progress 😊 |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Thanks to the previous contributors for their refactoring work, which removed a lot of unnecessary code. I only need to modify about 50 formatting errors instead of the 500 I mentioned in #90. 😊
Related issue