Fix Property Naming Issues #96
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
|
Thanks for this, @Linfye! Will check it later :) Very cool to have an example for other issues to work from to solve more linting problems 😊 |
There was a problem hiding this comment.
PR looks fine to me. Thank you for the contributions @Linfye. :)
.editorconfig
Outdated
| @@ -20,7 +20,7 @@ continuation_indent_size = 4 | |||
| wildcard_import_limit = 999 | |||
| ij_kotlin_name_count_to_use_star_import = 999 | |||
| ij_kotlin_name_count_to_use_star_import_for_members = 999 | |||
| ktlint_standard_property-naming = disabled | |||
| #ktlint_standard_property-naming = disabled | |||
There was a problem hiding this comment.
For the disabled ones, let's just delete them in the future :)
There was a problem hiding this comment.
I'll follow this in the next linting issue. Thanks for your review.😊
| @@ -393,12 +392,12 @@ abstract class BaseSimpleActivity : AppCompatActivity() { | |||
| } else { | |||
| funAfterSAFPermission?.invoke(false) | |||
| } | |||
| } else if (requestCode == DELETE_FILE_SDK_30_HANDLER) { | |||
| } else if (requestCode == Companion.DELETE_FILE_SDK_30_HANDLER) { | |||
There was a problem hiding this comment.
Nice :) Great work and thoughts on this, both of you!
There was a problem hiding this comment.
Really appreciate you picking this up, @Linfye! Really can't wait until we can look at the codebase and all of the ktlint/detekt issues are done! Gonna be great ✨
Contributor checklist
Description
This PR fixed ktlint issues of property naming.
Related issue