Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with file types and directory indicators #135

Closed
2 tasks done
andrewtavis opened this issue May 20, 2024 · 14 comments
Closed
2 tasks done

Update docs with file types and directory indicators #135

andrewtavis opened this issue May 20, 2024 · 14 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented May 20, 2024

Terms

Description

As discussed in Saturday's sync, it would be good to have a more explicit definition of the paths within the documentation. If we are going to the documentation of a file, then it would be great to have the filetype appended to the end of the navigation, and if we're going to a directory, then it'd be great if the navigation had a / at the end :)

This issue would apply this throughout the docs. I'll send along two examples of each of the above. The way that it can be tested locally is to cd into the docs directory and then do make html, which is a command from sphinx. From there, within build/html we can use live server to open index.html by right clicking it (see below):

Screenshot_2024-05-20 21 41 43

From there the local version of the docs will be opened in the default browser such that progress can be checked 😊

Contribution

@lillian-mo indicated that this issue would be of interest 😊 Feel free to write in here and I'll assign!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 20, 2024
@andrewtavis
Copy link
Member Author

@lillian-mo, 06d109a includes the two base examples that I did in the sync, which I confirmed as working locally. Let me know if there's anything else I can do to support!

@andrewtavis
Copy link
Member Author

Hey @lillian-mo 👋 Feel free to write in here so I can assign :) Also, I'll be doing the directory refactor today after all as I work through the current PR, but that should be done by EOD. I'll write in here when it's all done!

@andrewtavis
Copy link
Member Author

All the directory reordering has gone through now, so we're good to go for this! :)

@andrewtavis
Copy link
Member Author

Hey @lillian-mo 👋 Quick checkin on this :) Let me know if a call would help here! No stress if you're a bit busy 😊

@lillian-mo
Copy link

lillian-mo commented Jun 23, 2024 via email

@andrewtavis
Copy link
Member Author

No stress at all, @lillian-mo! Just checking in :) If it's midterms, then wait till they're done! And good luck! 🍀

@lillian-mo
Copy link

hey @andrewtavis super sorry about the delay! I should be able to get to this this weekend - I'll let you know if I need any help!

@andrewtavis
Copy link
Member Author

Sounds perfect, @lillian-mo! Looking forward to the review! :)

@lillian-mo
Copy link

@andrewtavis thanks! I've changed some of the links, but I can't seem to push these changes as the html isn't part of the directory - how should I do that?

@andrewtavis
Copy link
Member Author

Hey @lillian-mo! 👋 The changes should be going into the docs subdirectory here and then your changes would be reflected in there. So basically the .rst files, and then you can test it with the make html command from within the docs directory :) Hope this helps, and let me know if you'd like to chat about it!

@lillian-mo
Copy link

@andrewtavis super sorry for missing this! (also sorry for being super slow in general) Sounds good, will fix soon!

@andrewtavis
Copy link
Member Author

No stress at all, @lillian-mo! Take your time, and thanks for the communication here!

@andrewtavis
Copy link
Member Author

In progress via a recent discussion between @lillian-mo and I :) Let me know if any help's needed!

lillian-mo pushed a commit to lillian-mo/Scribe-Data that referenced this issue Aug 19, 2024
andrewtavis added a commit that referenced this issue Aug 21, 2024
Issue #135: Update docs with file types and directory indicators
@andrewtavis
Copy link
Member Author

Closed by #185 😊 Thanks so much for the help here, @lillian-mo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants