Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #135: Update docs with file types and directory indicators #185

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

lillian-mo
Copy link

Contributor checklist


Description

Copy link

github-actions bot commented Aug 19, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review August 19, 2024 05:54
@andrewtavis
Copy link
Member

Hey @lillian-mo 👋 One thing to note from our maintainer checklist is that it looks like your GitHub email isn't set up properly. Normally the commits for the PR should be authored by the same person and the icons should be the same as well. It looks like your Git user.name is set up properly, which indicates that it's likely your email. Can you check that the email you use for GitHub is the same as what you get for git config user.email. From there we can check if the PR fixes itself, or maybe we can reopen it :)

There's no "problem" with the code as it is, but if I were to merge this then your account wouldn't get the commit credit :)

@lillian-mo
Copy link
Author

Hey @lillian-mo 👋 One thing to note from our maintainer checklist is that it looks like your GitHub email isn't set up properly. Normally the commits for the PR should be authored by the same person and the icons should be the same as well. It looks like your Git user.name is set up properly, which indicates that it's likely your email. Can you check that the email you use for GitHub is the same as what you get for git config user.email. From there we can check if the PR fixes itself, or maybe we can reopen it :)

There's no "problem" with the code as it is, but if I were to merge this then your account wouldn't get the commit credit :)

Thanks for letting me know! I've configured my git user.email so that it's my personal email here. Hopefully that works :)

@andrewtavis
Copy link
Member

Nice! Do you want to reopen the PR regardless? Likely still won't give you the credit as it is :) Is good for us to have you listed as a contributor as well 😊

@andrewtavis
Copy link
Member

Hope it's ok that I close with the plan of reopening, @lillian-mo! Just go ahead and send along the same code and I'll quickly bring it in :)

@andrewtavis andrewtavis reopened this Aug 21, 2024
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reopening so we can close out the issue :) We do have you set up for future contributions, and maybe you can get the contribution this time 🤞

All looks great, @lillian-mo! Thanks so much for the contribution here :) :)

@andrewtavis andrewtavis merged commit c38747f into scribe-org:main Aug 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants