-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #135: Update docs with file types and directory indicators #185
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Hey @lillian-mo 👋 One thing to note from our maintainer checklist is that it looks like your GitHub email isn't set up properly. Normally the commits for the PR should be authored by the same person and the icons should be the same as well. It looks like your Git There's no "problem" with the code as it is, but if I were to merge this then your account wouldn't get the commit credit :) |
Thanks for letting me know! I've configured my git user.email so that it's my personal email here. Hopefully that works :) |
Nice! Do you want to reopen the PR regardless? Likely still won't give you the credit as it is :) Is good for us to have you listed as a contributor as well 😊 |
Hope it's ok that I close with the plan of reopening, @lillian-mo! Just go ahead and send along the same code and I'll quickly bring it in :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reopening so we can close out the issue :) We do have you set up for future contributions, and maybe you can get the contribution this time 🤞
All looks great, @lillian-mo! Thanks so much for the contribution here :) :)
Contributor checklist
Description