Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed tqdm loop so that we are using "with" #176

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

henrikth93
Copy link
Member

Changed the tqdm loop so that it is used together with "with", it enables us to prevent printing the progress bar on a failure/error.

Contributor checklist


Description

Related issue

Changed the tqdm loop so that it is used together with "with", it enables us to prevent printing the progress bar on a failure/error.
Copy link

github-actions bot commented Jul 19, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Quick note on GitHub, @henrikth93: It's best to request review in these cases rather than assign. I'm not really sure what assign would be in this case, but we don't really use it as a convention. Maybe in the future when we have more than one person working on a PR 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this locally and it's working great, @henrikth93! Thanks for taking this on! 🚀

@andrewtavis andrewtavis merged commit a5ce287 into scribe-org:main Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants