Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version message, add test for version #191

Merged
merged 6 commits into from
Aug 25, 2024

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Aug 25, 2024

Contributor checklist


Description

  • Fix version message
  • Add tests for Version Check. with command pytest tests

Related issue

Copy link

github-actions bot commented Aug 25, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review August 25, 2024 12:33
Copy link
Member

@mhmohona mhmohona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @axif0, looks like you have addressed the review in #170 (comment). Thanks for your great work! ✨

@andrewtavis, do you think for each command we should have separate test file like Asif has proposed?

@andrewtavis
Copy link
Member

Yes, I think that the way that @axif0 has it set up works well :) If the other tests in #170 could be split and added to tests/cli like the one here that would be great!

@andrewtavis
Copy link
Member

Thanks for the work here both of you! 😊

self, mock_latest_version, mock_local_version
):
"""
Tests the scenario where a newer version is available, suggesting an update.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor thing here that is more a personal thing for me, @axif0, I added the periods here as Python standards state that comments that are their own line should have a period at the end (and should also start with a capitalized work - they're full sentences). For inline comments it's best to not capitalize the first word and not end in a period :)

For next time! 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the changes here, and especially adding in the tests, @axif0! Great work! Thanks for all your contributions today :) :)

@andrewtavis andrewtavis merged commit 548fa92 into scribe-org:main Aug 25, 2024
3 checks passed
@andrewtavis andrewtavis mentioned this pull request Aug 25, 2024
2 tasks
@axif0 axif0 deleted the testing branch September 2, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants