-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix paths in test_check_query.py Windows compatible #198
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
@andrewtavis thank you so much. pathlib is more realistic to use here. @mhmohona In my windows environment, I got no error in testing, for double checking can you please verify it by running the wikidata test ? |
Thanks so much for the quick fixes here, @axif0! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewtavis I just checked. It seems things are working fine, without any error on Windows. ✨ and @axif0, good work. 👏🏾 |
Contributor checklist
Description
Added a function
normalize_path
. Here it takes a file system path as an input and returns a "normalized" version of that path.Related issue