Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths in test_check_query.py Windows compatible #198

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Sep 4, 2024

Contributor checklist


Description

Added a function normalize_path . Here it takes a file system path as an input and returns a "normalized" version of that path.
image

Related issue

Copy link

github-actions bot commented Sep 4, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review September 4, 2024 12:05
@andrewtavis
Copy link
Member

Hey @axif0 👋 Generally is looking good and I really like the inclusion of marks! Thanks for helping to organize the code :)

Would it be possible to leverage pathlib for this instead of os. In this way it'd be consistent with the rest of the project :)

@axif0
Copy link
Contributor Author

axif0 commented Sep 5, 2024

@andrewtavis thank you so much. pathlib is more realistic to use here.

@mhmohona In my windows environment, I got no error in testing, for double checking can you please verify it by running the wikidata test ?

@andrewtavis
Copy link
Member

Thanks so much for the quick fixes here, @axif0! :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick reaction to the comments, @axif0! @mhmohona, do let us know if you're seeing anything that needs to be done about the recent commits. For now we're good to merge 😊

@andrewtavis andrewtavis merged commit 95d8541 into scribe-org:main Sep 5, 2024
3 checks passed
@mhmohona
Copy link
Member

mhmohona commented Sep 6, 2024

Thanks for the quick reaction to the comments, @axif0! @mhmohona, do let us know if you're seeing anything that needs to be done about the recent commits. For now we're good to merge 😊

@andrewtavis I just checked. It seems things are working fine, without any error on Windows. ✨

and @axif0, good work. 👏🏾

@axif0 axif0 deleted the wikidatatest-fix branch October 3, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants