-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1. Modified the get_selection()
, select_languages()
and select_data_types()
functions
#216
Conversation
…valid input is provided. Add a loop in the select_languages() and select_data_types() functions to handle re-asking the question.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
get_selection()
function get_selection()
, select_languages() and
select_data_types()` functions
get_selection()
, select_languages() and
select_data_types()` functions get_selection()
, select_languages()
and select_data_types()
functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your great work @KesharwaniArpita!
Thank you @mhmohona |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to not be able to have this go into production, @KesharwaniArpita. Multiple people worked on this, and we need to focus on the version in #268 as that also adds in the interactive mode of the CLI. Hope you understand! I'll reference this as I go through that issue to make sure that we're doing it correctly 😊
Sureee! |
get_selection()
function to re-ask for input if no valid input is provided.select_languages()
andselect_data_types()
functions to handle re-asking the question.Contributor checklist
Related issue