Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Modified the get_selection() , select_languages() and select_data_types() functions #216

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

KesharwaniArpita
Copy link
Contributor

@KesharwaniArpita KesharwaniArpita commented Oct 3, 2024

  1. Modified the get_selection() function to re-ask for input if no valid input is provided.
  2. Added a loop in the select_languages() and select_data_types() functions to handle re-asking the question.
  3. Made the output options prompt also re-ask the user in case of an empty or invalid response.

Contributor checklist


Related issue

…valid input is provided. Add a loop in the select_languages() and select_data_types() functions to handle re-asking the question.
Copy link

github-actions bot commented Oct 3, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@KesharwaniArpita KesharwaniArpita changed the title 1. Modified the get_selection() function 1. Modified the get_selection() , select_languages() and select_data_types()` functions Oct 3, 2024
@KesharwaniArpita KesharwaniArpita changed the title 1. Modified the get_selection() , select_languages() and select_data_types()` functions 1. Modified the get_selection() , select_languages() and select_data_types() functions Oct 3, 2024
@andrewtavis andrewtavis self-requested a review October 3, 2024 21:05
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 7, 2024
Copy link
Member

@mhmohona mhmohona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work @KesharwaniArpita!

@KesharwaniArpita
Copy link
Contributor Author

Thank you @mhmohona

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to not be able to have this go into production, @KesharwaniArpita. Multiple people worked on this, and we need to focus on the version in #268 as that also adds in the interactive mode of the CLI. Hope you understand! I'll reference this as I go through that issue to make sure that we're doing it correctly 😊

@andrewtavis andrewtavis merged commit bcbf53f into scribe-org:main Oct 10, 2024
3 checks passed
@andrewtavis andrewtavis mentioned this pull request Oct 10, 2024
1 task
@KesharwaniArpita
Copy link
Contributor Author

Sorry to not be able to have this go into production, @KesharwaniArpita. Multiple people worked on this, and we need to focus on the version in #268 as that also adds in the interactive mode of the CLI. Hope you understand! I'll reference this as I go through that issue to make sure that we're doing it correctly 😊

Sureee!

@KesharwaniArpita KesharwaniArpita deleted the Issue209 branch October 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants