Create query_adverbs.sparql #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adverb for Basque
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
|
@Otom-obhazi: Are you checking for the forms for the adverbs? Please stop sending pull requests if all you're doing is copying the file and changing the language QID. Yes this is a contribution, but when I'm asking you to work on your current PRs to expand them and then you just send more of the same it's actually disruptive. If you're still unsure of how to check forma and expand them, then ask myself or other contributors. |
|
@andrewtavis i dont understand what you mean by checking forma and expanding them. |
|
I'm happy to explain, and please let me know that it's still confusing as you have just now rather than continuing to work. I'm wiring out a more detailed explanation now :) |
|
please can you help me with resources too..
thank you
…On Tue, 15 Oct 2024 at 16:29, Andrew Tavis McAllister < ***@***.***> wrote:
I'm happy to explain, and please let me know that it's still confusing as
you have just now rather than continuing to work. I'm wiring out a more
detailed explanation now :)
—
Reply to this email directly, view it on GitHub
<#374 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQTIX2BJ7WDD3WEN4GOSG2TZ3UYERAVCNFSM6AAAAABP7MCVTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJUGMYTONRUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
To expand on my explanation that I sent along here:
I'll go through now and merge in the PRs that don't have forms. This could be all of them or none of them, but I really would ask that you check for these things beforehand. The Estonian query for instance is dramatically more valuable because it includes all of its forms :) Let me know if there are further questions! I really appreciate your interest in the project. I hope you understand that I really needed you to pause for a moment so I could explain some things to you so that you can have a better impact on the project 😊 |
What do you mean by resources? |
|
Something that can help me understand better what you want to do.
…On Tue, 15 Oct 2024, 4:54 pm Andrew Tavis McAllister, < ***@***.***> wrote:
please can you help me with resources too..
thank you
What do you mean by resources?
—
Reply to this email directly, view it on GitHub
<#374 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQTIX2AGFXXP26QOHN3JYF3Z3U3CVAVCNFSM6AAAAABP7MCVTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJUGQYTANZZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
You can check the following:
|
andrewtavis
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Similar for this one, let's be sure to have all directories be lower case except for Languages, @Otom-obhazi :)
|
Thanks for the help! |
|
something like this
#381
replying to :
To expand on my explanation that I sent along here
<#362 (comment)>
:
- Let's take for example the query for Slovak adjectives
src/scribe_data/language_data_extraction/Slovak/adjecives/query_adjectives.sparql
<https://github.com/scribe-org/Scribe-Data/blob/main/src/scribe_data/language_data_extraction/Slovak/adjecives/query_adjectives.sparql>
- Let's take this query over to query.wikidata.org, but with one edit to
return to lexeme URI via ?lexeme
- You can see the edited query in the Wikidata Query Service here
<https://w.wiki/BYW8>
- Note that it includes ?lexeme
- Run the query and look at the results
- Click on the first result, which will be random, and for me was
wikidata.org/wiki/Lexeme:L238355
<https://www.wikidata.org/wiki/Lexeme:L238355>
- This is the Slovak adjective slovenský (the adjective conveniently
means Slovak)
- This is the base adjective, but in Slovak specifically we need to
also get forms for the adjectives as they're different based on if the
thing is masculine, feminine, etc
- You can see all of these other forms on the Wikidata page when you
scroll down
- There are forms based on masculine vs. feminine, singular vs.
plural and the case that's used
- These are the forms that we also want to include in our data outputs
- Some of the queries you've sent along don't have forms, so they're
fine, but we need to check for the forms before sending them along
- An example of a query for adverbs with tons of forms is
src/scribe_data/language_data_extraction/Estonian/adverbs/query_adverbs_1.sparql
<https://github.com/scribe-org/Scribe-Data/blob/c64ea865531ff2de7fe493266d0be0f6be7e5518/src/scribe_data/language_data_extraction/Estonian/adverbs/query_adverbs_1.sparql>
- Slovak is similar to Estonian in these regards, that there are many
forms and they're complex
- We need to construct forms with an optional selection that includes
all the properties that are on the form
- For the first form above slovenský we need to find the Wikidata
QIDs for masculine <https://www.wikidata.org/wiki/Q499327>, nominative
case <https://www.wikidata.org/wiki/Q131105>, singular
<https://www.wikidata.org/wiki/Q110786>, positive
<https://www.wikidata.org/wiki/Q3482678>
- Then put these within the optional selection to get the form in a
way that the returned value is unique
I'll go through now and merge in the PRs that don't have forms. This could
be all of them or none of them, but I really would ask that you check for
these things beforehand. The Estonian query for instance is dramatically
more valuable because it includes all of its forms :)
Let me know if there are further questions! I really appreciate your
interest in the project. I hope you understand that I really needed you to
pause for a moment so I could explain some things to you so that you can
have a better impact on the project 😊
…On Tue, 15 Oct 2024 at 17:47, Andrew Tavis McAllister < ***@***.***> wrote:
Merged #374 <#374> into
main.
—
Reply to this email directly, view it on GitHub
<#374 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQTIX2CBMDRLYDXINL3FBBDZ3VBLLAVCNFSM6AAAAABP7MCVTSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGY3DCMJRGY2DENY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
or this >>>>
Otom-obhazi@4801aed
…On Wed, 16 Oct 2024 at 13:05, Angel Osim ***@***.***> wrote:
something like this
#381
replying to :
To expand on my explanation that I sent along here
<#362 (comment)>
:
- Let's take for example the query for Slovak adjectives
src/scribe_data/language_data_extraction/Slovak/adjecives/query_adjectives.sparql
<https://github.com/scribe-org/Scribe-Data/blob/main/src/scribe_data/language_data_extraction/Slovak/adjecives/query_adjectives.sparql>
- Let's take this query over to query.wikidata.org, but with one edit
to return to lexeme URI via ?lexeme
- You can see the edited query in the Wikidata Query Service here
<https://w.wiki/BYW8>
- Note that it includes ?lexeme
- Run the query and look at the results
- Click on the first result, which will be random, and for me was
wikidata.org/wiki/Lexeme:L238355
<https://www.wikidata.org/wiki/Lexeme:L238355>
- This is the Slovak adjective slovenský (the adjective
conveniently means Slovak)
- This is the base adjective, but in Slovak specifically we need to
also get forms for the adjectives as they're different based on if the
thing is masculine, feminine, etc
- You can see all of these other forms on the Wikidata page when
you scroll down
- There are forms based on masculine vs. feminine, singular vs.
plural and the case that's used
- These are the forms that we also want to include in our data
outputs
- Some of the queries you've sent along don't have forms, so they're
fine, but we need to check for the forms before sending them along
- An example of a query for adverbs with tons of forms is
src/scribe_data/language_data_extraction/Estonian/adverbs/query_adverbs_1.sparql
<https://github.com/scribe-org/Scribe-Data/blob/c64ea865531ff2de7fe493266d0be0f6be7e5518/src/scribe_data/language_data_extraction/Estonian/adverbs/query_adverbs_1.sparql>
- Slovak is similar to Estonian in these regards, that there are
many forms and they're complex
- We need to construct forms with an optional selection that
includes all the properties that are on the form
- For the first form above slovenský we need to find the Wikidata
QIDs for masculine <https://www.wikidata.org/wiki/Q499327>, nominative
case <https://www.wikidata.org/wiki/Q131105>, singular
<https://www.wikidata.org/wiki/Q110786>, positive
<https://www.wikidata.org/wiki/Q3482678>
- Then put these within the optional selection to get the form in a
way that the returned value is unique
I'll go through now and merge in the PRs that don't have forms. This could
be all of them or none of them, but I really would ask that you check for
these things beforehand. The Estonian query for instance is dramatically
more valuable because it includes all of its forms :)
Let me know if there are further questions! I really appreciate your
interest in the project. I hope you understand that I really needed you to
pause for a moment so I could explain some things to you so that you can
have a better impact on the project 😊
On Tue, 15 Oct 2024 at 17:47, Andrew Tavis McAllister <
***@***.***> wrote:
> Merged #374 <#374> into
> main.
>
> —
> Reply to this email directly, view it on GitHub
> <#374 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AQTIX2CBMDRLYDXINL3FBBDZ3VBLLAVCNFSM6AAAAABP7MCVTSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGY3DCMJRGY2DENY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adverb for Basque
Contributor checklist
Description
Related issue