Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check for sparql and for json in workflow #392

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Oct 16, 2024

Contributor checklist


Description

Some query files contain _1, _2, _3 at the end. Our code now check if query_{item} and lastly .sparql or not. Added check for "{item}_queried.json" and "format_{item}.py" also.

Related issue

Copy link

github-actions bot commented Oct 16, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 16, 2024 21:54
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 16, 2024
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's working really well, @axif0! Really thanks so much for this :) Is already paying off having it, and am really looking forward to the first failed PR 😊

@andrewtavis andrewtavis merged commit 9767fee into scribe-org:main Oct 16, 2024
5 checks passed
@axif0 axif0 deleted the workflow_error branch October 17, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants