Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PythonPath and fixed emoji generation for windows #406

Closed
wants to merge 3 commits into from

Conversation

SethiShreya
Copy link
Contributor

Signed off by Shreya Sethi
[email protected]

  • Update the docs to set the python path globally
  • Fixed minor issues related to emoji generation for windows

Note: I haven't fixed file path issue in generate_emoji_keywords.py files as it is being worked on by others. Everything else is working fine

Run this command to test

scribe-data get --lang english -dt emoji_keywords

Copy link

github-actions bot commented Oct 17, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 17, 2024
@andrewtavis andrewtavis self-requested a review October 17, 2024 17:14
@andrewtavis
Copy link
Member

I'm wondering on this PR, @SethiShreya 🤔 Could we look into @axif0's solution in #407 that might fix this "automatically" and also download the appropriate file? The default JSON export path is also set to the export path, but we'd like it to be what the user sets. I need a bit more time to consider the options of how to deal with this.

@andrewtavis
Copy link
Member

Closing this as the hope is that the issues are resolved via #480 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants