-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dagbani dir #416
Dagbani dir #416
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Ebeleokolo 👋
I really would ask that you put a bit more care into the work that you send along. This PR had empty files that we do not need, repeat files of all kinds, and the queries it did include needed a lot of work. Can you please reference the new SPARQL query writing docs before further work?
Thanks for the contribution! :)
Please also fill out the commit message with the needed information in the future :) |
Hello @andrewtavis , thank you for the feedback and i apologize for that. I have to look into this again before further contribution as it seem it may be coming from my dev environment. |
This PR introduces the SPARQL query that expands the Dagbani Verbs, Nouns and Adjectives.
The query was tested using the Wikidata query service.
Any feedback or suggestions are greatly appreciated.
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
Related issue