-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update query_verbs.sparql #422
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Hey @Otom-obhazi 👋 For this and your other PR, could you please remove all inline comments that are saying what the identifiers are. These add to query length and processing time. If you use VS Code, there's an extension mentioned in the contributing guide that will tell you what the QIDs are on hover. I'll get to the review of both once these changes go through :) Thank you! |
This query also returns no results for any of the forms. Can you please reference the new SPARQL query writing docs and make the needed changes to get all the forms? Thank you :) |
@andrewtavis sorry for the mistake, ill do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like none of these forms have data, @Otom-obhazi, so I removed them :)
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
Related issue