-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move language_data_extraction under wikidata and lowercase languages #454
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
@catreedle, sorry could you address the merge conflicts? Maybe the easiest thing to do would be to redo this PR from main and I'll make sure to bring it in before other PRs? |
We could even do a call for this at some point to make sure we're in sync? |
sure, @andrewtavis. on it |
sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the failed test here as it's passing locally. Let's bring this in so that other people can work from it, @catreedle :) Thanks for this!
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This PR
language_data_extraction
and its contents under wikidataemoji_keywords
andgenerate_emoji_keywords
in language/sub-language directoriesRelated issue
language_data_extraction
under/wikidata
and lower case all languages #446