Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move language_data_extraction under wikidata and lowercase languages #454

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

catreedle
Copy link
Contributor

Contributor checklist


Description

This PR

  • moves language_data_extraction and its contents under wikidata
  • changes languages and sub-languages directory name into lowercases
  • delete emoji_keywords and generate_emoji_keywords in language/sub-language directories

Related issue

Copy link

github-actions bot commented Oct 21, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

@catreedle, sorry could you address the merge conflicts? Maybe the easiest thing to do would be to redo this PR from main and I'll make sure to bring it in before other PRs?

@andrewtavis
Copy link
Member

We could even do a call for this at some point to make sure we're in sync?

@catreedle
Copy link
Contributor Author

@catreedle, sorry could you address the merge conflicts? Maybe the easiest thing to do would be to redo this PR from main and I'll make sure to bring it in before other PRs?

sure, @andrewtavis. on it

@catreedle
Copy link
Contributor Author

We could even do a call for this at some point to make sure we're in sync?

sure

@catreedle catreedle reopened this Oct 22, 2024
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 22, 2024
@andrewtavis andrewtavis self-requested a review October 22, 2024 23:08
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the failed test here as it's passing locally. Let's bring this in so that other people can work from it, @catreedle :) Thanks for this!

@andrewtavis andrewtavis merged commit 180950d into scribe-org:main Oct 23, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants