-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement autosuggestions generation in get_data function #462
Closed
Commits on Oct 21, 2024
-
Expand Hausa data queries for nouns, proper nouns, and verbs
- Enhanced noun query to include definite and indefinite forms - Updated proper noun query with definite and vocative forms - Expanded verb query to cover past simple, present continuous, future tense, and imperative forms - Added comments and FILTER options for both Latin and Arabic script variants - Improved overall query structure and readability
Configuration menu - View commit details
-
Copy full SHA for 4172419 - Browse repository at this point
Copy the full SHA 4172419View commit details -
Implement autosuggestions generation in get_data function
This commit integrates the autosuggestions functionality from process_wiki.py into the get_data function in get.py. Key changes include: 1. Import gen_autosuggestions function from scribe_data.wikipedia.process_wiki 2. Add new conditional block to handle 'autosuggestions' data type 3. Implement autosuggestions generation logic for specified languages 4. Add placeholder load_text_corpus function for future implementation The autosuggestions block now: - Iterates through specified languages - Loads text corpus (placeholder function to be implemented) - Calls gen_autosuggestions with appropriate parameters - Sets update_local_data=True to save results - Uses interactive mode for verbose output This update allows CLI users to generate autosuggestions directly via the get command, streamlining the data generation process. Note: The load_text_corpus function needs to be implemented to load the actual text corpus for each language before this feature is fully functional. TODO: - Implement load_text_corpus function - Ensure correct file paths and imports across the project - Add error handling for corpus loading and autosuggestions generation - Update documentation to reflect new autosuggestions functionality in CLI
Configuration menu - View commit details
-
Copy full SHA for cdc2f52 - Browse repository at this point
Copy the full SHA cdc2f52View commit details
Commits on Oct 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e2e9546 - Browse repository at this point
Copy the full SHA e2e9546View commit details -
Configuration menu - View commit details
-
Copy full SHA for 886ed00 - Browse repository at this point
Copy the full SHA 886ed00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80920c4 - Browse repository at this point
Copy the full SHA 80920c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcbfda2 - Browse repository at this point
Copy the full SHA fcbfda2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f75976 - Browse repository at this point
Copy the full SHA 8f75976View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff56e71 - Browse repository at this point
Copy the full SHA ff56e71View commit details
Commits on Oct 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8465145 - Browse repository at this point
Copy the full SHA 8465145View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.