Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation branch #463

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Conversation

AnishereMariam
Copy link
Contributor

Description

  • My pull request solved the issue Render Jupyter notebooks inside the Scribe-Data documentation #210. I was able to render the notebook in a toctree.
    Although, I have a bit of a challenge. I tried referring to the .ipynb file directly from the src folder, but it kept returning an error. I had to copy the file into the .rst folder for it to work. I am open to suggestions on how to fix that.

*I had other commits on this PR that fixed some minor bugs I encountered while running the docs file.
I fixed some indentations and code errors that affect the complete display of the Documentation file.

Testing

-->I tested my changes with the sphinx-build tool and am confident it works.

Issue fixed

#210 and some minor bugs.

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Hi @AnishereMariam 👋 Thanks for the efforts here! The notebook isn't showing up for me locally, but mybe it's how I'm building the docs. I always test with make html. Can you let me know what the command you're using is?

@AnishereMariam
Copy link
Contributor Author

I test mine with sphinx-build -t html source build.
I am unable to use make html

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info, @AnishereMariam :) I realized that the problem for me was local likely, as I didn't have pandoc installed apparently. I changed one thing to make it so that the notebooks are never ran. This is really awesome 😊 Thanks so much for the great work here! Maybe we can work on some notebook based usage examples at some point :)

@andrewtavis andrewtavis merged commit ea84bcd into scribe-org:main Oct 22, 2024
6 checks passed
@AnishereMariam
Copy link
Contributor Author

I would love to explore this phase more. It exposed me to some valuable learning experiences. I really enjoy working on this project, generally.

@andrewtavis
Copy link
Member

Really enjoy having you on the project, @AnishereMariam :) You've had some great contributions :)

@andrewtavis
Copy link
Member

If you have some further suggestions on how to improve the documentation, then please share!

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants