-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow query forms #476
Workflow query forms #476
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Thanks for this, @axif0! Can you bring in main that has the language directories under Wikidata? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work, @axif0! Appreciate this a lot as it's going to improve our ability to maintain the queries so much 😊
|
||
if has_optional_blocks: | ||
return "" # skip check for queries with OPTIONAL blocks | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m sorry, but in this part I don't understand why you guys @andrewtavis @axif0 skipped queries that contain the OPTIONAL
statement:
# Check if query has any OPTIONAL blocks.
optional_pattern = r"OPTIONAL\s*\{"
has_optional_blocks = bool(re.search(optional_pattern, query_text))
if has_optional_blocks:
return "" # skip check for queries with OPTIONAL blocks
Almost all the queries that have been or will be written will include an OPTIONAL
statement, and this is where many people (including myself) often do errors.
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
CC: @andrewtavis Not sure if is it how we wanted and also try to touch all corner cases.
Related issue