Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow query forms #476

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Oct 23, 2024

Contributor checklist


Description

  • Add in a check for whether all forms are actually returned in the query (i.e. are there optional selections that are not brought up to the select statement)
  • Add a check that each returned form is unique (never ?plural ?plural)

CC: @andrewtavis Not sure if is it how we wanted and also try to touch all corner cases.

Related issue

Copy link

github-actions bot commented Oct 23, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 23, 2024 22:10
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 23, 2024
@andrewtavis
Copy link
Member

Thanks for this, @axif0! Can you bring in main that has the language directories under Wikidata? :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work, @axif0! Appreciate this a lot as it's going to improve our ability to maintain the queries so much 😊

@andrewtavis andrewtavis merged commit 52c8363 into scribe-org:main Oct 24, 2024
6 checks passed

if has_optional_blocks:
return "" # skip check for queries with OPTIONAL blocks

Copy link
Contributor

@OmarAI2003 OmarAI2003 Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m sorry, but in this part I don't understand why you guys @andrewtavis @axif0 skipped queries that contain the OPTIONAL statement:

# Check if query has any OPTIONAL blocks.
optional_pattern = r"OPTIONAL\s*\{"
has_optional_blocks = bool(re.search(optional_pattern, query_text))

if has_optional_blocks:
    return ""  # skip check for queries with OPTIONAL blocks

Almost all the queries that have been or will be written will include an OPTIONAL statement, and this is where many people (including myself) often do errors.

@axif0 axif0 deleted the workflow_query_forms branch October 27, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants