Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat enhancement Interactive UI language & data-type #487

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Oct 25, 2024

Contributor checklist


Description

Using existing prompt_toolkit to show languages and data-types in a better way.

@andrewtavis Not sure if you like the idea. if not we can skip the PR.

interactive2

Copy link

github-actions bot commented Oct 25, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

andrewtavis commented Oct 26, 2024

This is definitely an interesting idea, @axif0! What would you say are the benefits of it? :) I'm definitely inclined to merge 😊

@andrewtavis andrewtavis added hacktoberfest Included as a part of Hacktoberfest hacktoberfest-accepted Accepted as a part of Hacktoberfest and removed hacktoberfest Included as a part of Hacktoberfest labels Oct 26, 2024
@axif0
Copy link
Contributor Author

axif0 commented Oct 26, 2024

Umm...There are lots of languages to show in interactive mode on a single column. Initially my idea was to show them in a table with multiple column. But it seems that current libraries are not capable for that to show and as well as select them.

Therefore I think it is a good idea to use alternative ideas.

@andrewtavis andrewtavis self-requested a review October 26, 2024 19:37
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @axif0 :) Didn't explain my question well, but I actually was wondering if there were other options, with specifically the table view coming to mind. I think that this is the best functionality we could conceivably do 😊 Really appreciate the initiative!

@andrewtavis andrewtavis merged commit 6bf37ca into scribe-org:main Oct 26, 2024
8 checks passed
@axif0 axif0 deleted the testinginter branch October 27, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants