Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get cmd for dt and small bug fix #493

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Oct 27, 2024

Contributor checklist


Description

Added scribe-data get --all -dt nouns (gets all nouns for all language) and added more error handling in CLI command.

Related issue

Copy link

github-actions bot commented Oct 27, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

This is meant to integrate the work from @KesharwaniArpita in #491?

@axif0
Copy link
Contributor Author

axif0 commented Oct 27, 2024

This is meant to integrate the work from @KesharwaniArpita in #491?

Ya.. For avoiding the conflict and simplicity I copied @KesharwaniArpita `s get.py and then implement further changes.

Also, working on the test cases that are showing error.

@andrewtavis andrewtavis self-requested a review October 27, 2024 11:53
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 27, 2024
@@ -79,44 +79,67 @@ def get_data(
-------
The requested data saved locally given file type and location arguments.
"""
# MARK: Defaults
# Mark: Defaults
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note on marks, @KesharwaniArpita and @axif0: They only work when they're all caps :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvements to this, @axif0 :) Thanks for the continued work to improve the user experience! Thanks also @KesharwaniArpita for the initial work here :)

@andrewtavis andrewtavis merged commit 081d628 into scribe-org:main Oct 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants