-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate words from Russian to other Scribe languages #89
Translate words from Russian to other Scribe languages #89
Conversation
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you! Maintainer checklist
|
Signed-off-by: Shashank Mittal <[email protected]>
for item in json_data: | ||
word_list.append(item["word"]) | ||
|
||
src_lang="Russian" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify the src_lang
variable to specify the source language for the translations.
Keep the rest of the translate_words.py
script unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥 Nice, @shashank-iitbhu :) I'll take a bit more of a look at this, and maybe we can move this to an all caps var at the top. I can handle this myself though 😊
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
This PR can be tested by running This will also test #88. |
Note that the Linux tests don't work if we don't have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the contributions here, @shashank-iitbhu! Great stuff 😊 I already switched over the English translation process to match the Russian one, and will direct the others to send along their own versions and run it once for the examples. Lots of changes coming along to change the structure, and I'll also finalize the initial docs in #57 as we can't automodule/autodoc a lot of our files as they're scripts :)
Contributor checklist
Description
translate_words.py
tosrc/scribe_data/extract_transform/languages/Russian/translation
Related issue