-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scribe-Data Logo into Docs Sidebar and Update Color Scheme #92
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you! Maintainer checklist
|
docs/source/conf.py
Outdated
'display_version': False, | ||
} | ||
|
||
# importing custom css for theme customization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick note on this is it'd be great if comments were complete sentences with capitalization and a period at the end in the future, but no stress 😊 If they're inline comments then we can ignore the capitalization and punctuation, but it's Python style that comments that are their own line are fully formatted sentences :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewtavis, Thank you for your guideline. I will keep it in mind in future. so after merging this PR, now I am seeing texts in sidebar becomes white when I hover mouse on them - |
Would make sense to do an issue for this, @mhmohona! Thanks for checking! |
@andrewtavis, instead of issue, I submitted the #100, hopefully which is gonna fix the problem. |
Thank you! I'll take a look as soon as I can :) |
Contributor checklist
Description
Changes made:
ScribeDataLogo.png
(logo) to the_static
folder.conf.py
to includehtml_logo
and reference the new logo.custom.css
with styles for sidebar header color, text color, and logo padding.Tested locally to ensure that the layout appears correctly and that the logo is properly integrated within the sidebar.
Related issue