bn254_syscalls #828
Merged
bn254_syscalls #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcalancea
force-pushed
the
mihai/bn254-syscalls
branch
3 times, most recently
from
55df130 to
fbf16d3
Compare
mcalancea
force-pushed
the
mihai/bn254-syscalls
branch
from
fbf16d3 to
a2f3d4e
Compare
naure
approved these changes
Feb 27, 2025
| WriteMEM::construct_circuit( | ||
| cb, | ||
| start_addr.expr() + (i * WORD_SIZE) as u64, |
There was a problem hiding this comment.
The witness start_address could be removed, right?
| bn254_fp2_add_config: | ||
| <LargeEcallDummy<E, Bn254Fp2AddSpec> as Instruction<E>>::InstructionConfig, | ||
| bn254_fp2_mul_config: | ||
| <LargeEcallDummy<E, Bn254Fp2MulSpec> as Instruction<E>>::InstructionConfig, |
There was a problem hiding this comment.
Note: Eventually the ecall circuit can be adapted to have a single circuit for all ecalls, or one circuit per common shape of arguments (1 or 2 pointers). That will be more efficient to verify.
(Not for this PR)
| @@ -59,15 +58,15 @@ impl<E: ExtensionField, S: SyscallSpec> Instruction<E> for LargeEcallDummy<E, S> | |||
| .map(|i| { | |||
| let val_before = cb.create_witin(|| format!("mem_before_{}", i)); | |||
| let val_after = cb.create_witin(|| format!("mem_after_{}", i)); | |||
|
|
|||
| let addr = cb.create_witin(|| format!("addr_{}", i)); | |||
There was a problem hiding this comment.
In principle it could also be two witnesses for the two pointer arguments (e.g. p and q) and then the consecutive addresses of each one.
(Not required in this PR)
|
|
||
| fn main() { | ||
| let log_flag = true; | ||
| let log_state = |state: &[u32]| { |
| F: From<[Word; WORDS]> | ||
| + Into<[Word; WORDS]> | ||
| + std::ops::Add<Output = F> | ||
| + std::ops::Mul<Output = F>, |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds interface for precompiles pertaining to the
bn254elliptic curve. Mostly follows the structure of the existing precompiles.Caveats:
ecallcircuit to accept arbitrary memory addresses, as opposed to consecutive addresses as it does now. As discussed with @naure, this requires more attention; but I think the review can happen in parallel