Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash filename to make cache file shorter #834

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

hero78119
Copy link
Collaborator

This fix "Os file name too long" if challenge got to be large

This was referenced Feb 20, 2025
@lispc
Copy link
Collaborator

lispc commented Feb 24, 2025

btw do you know how long does "load_tables" takes? if just several seconds, i think we don't need the complex save/load/cache mechanism...

@hero78119
Copy link
Collaborator Author

btw do you know how long does "load_tables" takes? if just several seconds, i think we don't need the complex save/load/cache mechanism...

yeah we have #205 #206 PR which shows that load_tables which occupied > 75% of unittest time, probably more than 5 secs. This mechanism in particular benefits when we run multiple unittests

@hero78119 hero78119 added this pull request to the merge queue Feb 24, 2025
Merged via the queue into scroll-tech:master with commit 39db596 Feb 24, 2025
4 checks passed
@hero78119 hero78119 deleted the feat/sha256_filename branch February 24, 2025 01:49
@lispc
Copy link
Collaborator

lispc commented Feb 24, 2025

oh yes i realized the MockProver is run concurrently with dozens of unittests..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants