Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpcs: cleanup bunch of unnecessary basefold bit reverse operation #844

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

hero78119
Copy link
Collaborator

@hero78119 hero78119 commented Mar 4, 2025

Extracted from #843
This PR retain nice property and clean up bunch of unnessesary bit reverse across mpcs basefold prover/verifier.
The core idea is to retain raw message in even-odd fold, which match the sumcheck implementation parameter binding order.

@hero78119 hero78119 marked this pull request as draft March 4, 2025 09:26
@hero78119 hero78119 force-pushed the feat/reverse_bit_cleanup branch 2 times, most recently from f09b76c to 7a6bb31 Compare March 4, 2025 12:43
@hero78119 hero78119 marked this pull request as ready for review March 4, 2025 12:45
@hero78119
Copy link
Collaborator Author

For fibonacci 2^20 e2e it bring ~3-4% latency improvement

fibonacci_max_steps_1048576/prove_fibonacci/fibonacci_max_steps_1048576
                        time:   [3.8632 s 3.8857 s 3.9076 s]
                        change: [-4.6226% -3.7207% -2.7579%] (p = 0.00 < 0.05)
                        Performance has improved.

@hero78119 hero78119 requested a review from yczhangsjtu March 4, 2025 12:46
@hero78119 hero78119 changed the title mpcs: simplify basefold bit reverse mpcs: cleanup bunch of unnecessary basefold bit reverse operation Mar 4, 2025
@hero78119 hero78119 added the enhancement New feature or request label Mar 4, 2025
@hero78119 hero78119 force-pushed the feat/reverse_bit_cleanup branch 2 times, most recently from 911ff83 to cca6590 Compare March 4, 2025 13:08
@hero78119 hero78119 force-pushed the feat/reverse_bit_cleanup branch from cca6590 to 5412776 Compare March 4, 2025 13:10
@hero78119 hero78119 added this pull request to the merge queue Mar 5, 2025
Merged via the queue into scroll-tech:master with commit 254e92f Mar 5, 2025
4 checks passed
@hero78119 hero78119 deleted the feat/reverse_bit_cleanup branch March 5, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants