bug fix: e2e missed proof validity check #854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
changed the title
hero78119
commented
Mar 6, 2025
| @@ -148,7 +148,11 @@ fn main() { | |||
| // do statistics | |||
| let stat_recorder = StatisticRecorder::default(); | |||
| let transcript = TranscriptWithStat::new(&stat_recorder, b"riscv"); | |||
| verifier.verify_proof(zkvm_proof.clone(), transcript).ok(); | |||
There was a problem hiding this comment.
this check was missing before fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously end-to-end (e2e) tests were missing an assertion check for
verify_proof, meaning that failed proofs due to the absence of a halt instruction were not properly detected.Since the absence of a halt instruction can be a valid scenario (as execution can be controlled via max_step), this PR: