Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable Darwin for deterministic deployment #25

Merged
merged 9 commits into from
Aug 28, 2024
Merged

feat: enable Darwin for deterministic deployment #25

merged 9 commits into from
Aug 28, 2024

Conversation

Thegaram
Copy link
Contributor

The first commits are just merging Xi's recent changes. I recommend only reviewing from commit ebffab7.

Thegaram
Thegaram commented Aug 26, 2024
View reviewed changes
Copy link
Contributor Author

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiweichi Something's wrong with the tests, it seems they're run on the wrong branch (fails on src/test/alternative-gas-token/AlternativeGasTokenTestBase.t.sol, which is not part of this PR).

@zimpha
Copy link
Member

zimpha commented Aug 27, 2024

@yiweichi Something's wrong with the tests, it seems they're run on the wrong branch (fails on src/test/alternative-gas-token/AlternativeGasTokenTestBase.t.sol, which is not part of this PR).

seems related to I delete some used function in ScrollChain, I can help to fix it.

@zimpha
Copy link
Member

zimpha commented Aug 27, 2024

@yiweichi Something's wrong with the tests, it seems they're run on the wrong branch (fails on src/test/alternative-gas-token/AlternativeGasTokenTestBase.t.sol, which is not part of this PR).

seems related to I delete some used function in ScrollChain, I can help to fix it.

fixed in c996d14

Thegaram
Thegaram commented Aug 27, 2024
View reviewed changes
Copy link
Contributor Author

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@yiweichi yiweichi merged commit 560aad6 into feat-deterministic-deployment Aug 28, 2024
2 checks passed
@yiweichi yiweichi deleted the feat-enable-darwin-for-scroll-sdk branch August 28, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimpha zimpha zimpha approved these changes

@yiweichi yiweichi yiweichi approved these changes

@colinlyguo colinlyguo colinlyguo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thegaram @zimpha @yiweichi @colinlyguo