Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test to check deterministic addresses #35

Merged

Conversation

Thegaram
Copy link
Contributor

@Thegaram Thegaram commented Sep 4, 2024

Add test to check deterministic addresses. This way, if we change contracts in the future, we can easily detect which contract addresses are affected.

To do this, I needed to move the config toml reading logic from the Configuration contract's constructor into a readConfig function.

Copy link
Member

@yiweichi yiweichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM.

@yiweichi yiweichi merged commit 611913c into feat-deterministic-deployment Sep 6, 2024
2 checks passed
@yiweichi yiweichi deleted the feat-test-deterministic-addresses branch September 6, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants