Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add solidity test coverage #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ayenesimo1i
Copy link

Follow up to this

Added a small bit of coverage to ScrollStandardERC20Factory.sol, ETHRateLimiter.sol and TokenRateLimiter.sol, bringing all three to 100% coverage.

Copy link

@remingtony31 remingtony31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some recommendations for the PR on Solidity test coverage:

Error Handling: Ensure tests cover all edge cases, especially unexpected inputs (e.g., invalid addresses, overflow conditions).
Test Clarity: Make test descriptions clear and self-explanatory. Use more descriptive names for test cases, making it easier to understand failures.
Boundary Conditions: Add tests for minimum and maximum input values to ensure the contract handles limits well.
Code Coverage Report: Consider adding a code coverage report to track how much of the codebase is covered by tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants