Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support local prover && multiple task types #54

Merged
merged 38 commits into from
Feb 20, 2025

Conversation

yiweichi
Copy link
Member

@yiweichi yiweichi commented Jan 5, 2025

  1. Support local prover
  2. Support multiple task types in one prover process

@yiweichi yiweichi changed the title feat: local prover && support multiple task types feat: support local prover && support multiple task types Jan 5, 2025
@yiweichi yiweichi changed the title feat: support local prover && support multiple task types feat: support local prover && multiple task types Jan 5, 2025
@yiweichi yiweichi requested review from georgehao and Thegaram January 6, 2025 07:07
@georgehao
Copy link
Member

Actually, I think we should combine this repo and prover repo to small one, let this repo become a crate of prover. wdyt @Thegaram

the layout maybe like this

prover
---- cargo.toml
        cargo.lock
        crates
           ----  wrapper ( contains coordinator client, geth client, circuit, etc)
           ----  local
           ----  remote  

@georgehao
Copy link
Member

for the easily usage, we should simpfy some config option like n_workers http option, we should have a default value for it, ane make it to a optional field.

@Thegaram
Copy link
Contributor

Side note: Once this is merged, please submit a PR to https://github.com/Sindri-Labs/sindri-scroll-sdk (should be just a few simple fixes).

@Thegaram
Copy link
Contributor

Actually, I think we should combine this repo and prover repo to small one, let this repo become a crate of prover

We discussed this offline, but just so that we have info here:

@yiweichi yiweichi requested a review from georgehao January 21, 2025 18:45
@yiweichi yiweichi requested a review from colinlyguo February 18, 2025 01:38
@yiweichi yiweichi merged commit 41196f5 into main Feb 20, 2025
1 check passed
@yiweichi yiweichi deleted the feat-integrate-proving-sdk branch February 20, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants