Skip to content

Commit

Permalink
change some fmt.Errorf to errors.New
Browse files Browse the repository at this point in the history
  • Loading branch information
colinlyguo committed Jul 30, 2024
1 parent e0903ef commit 38f926b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion coordinator/internal/logic/auth/login.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func (l *LoginLogic) Check(login *types.LoginParameter) error {
version.Version, login.Message.ProverVersion)
}
// if the prover reports a same prover version
return fmt.Errorf("incompatible vk. please check your params files or config files")
return errors.New("incompatible vk. please check your params files or config files")
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion coordinator/internal/logic/provertask/prover_task.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (

var (
// ErrCoordinatorInternalFailure coordinator internal db failure
ErrCoordinatorInternalFailure = fmt.Errorf("coordinator internal error")
ErrCoordinatorInternalFailure = errors.New("coordinator internal error")
)

var (
Expand Down
5 changes: 2 additions & 3 deletions coordinator/internal/logic/submitproof/proof_receiver.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"encoding/json"
"errors"
"fmt"
"strings"
"time"

Expand Down Expand Up @@ -138,11 +137,11 @@ func (m *ProofReceiverLogic) HandleZkProof(ctx *gin.Context, proofParameter coor
m.proofReceivedTotal.Inc()
pk := ctx.GetString(coordinatorType.PublicKey)
if len(pk) == 0 {
return fmt.Errorf("get public key from context failed")
return errors.New("get public key from context failed")
}
pv := ctx.GetString(coordinatorType.ProverVersion)
if len(pv) == 0 {
return fmt.Errorf("get ProverVersion from context failed")
return errors.New("get ProverVersion from context failed")
}

proverTask, err := m.proverTaskOrm.GetProverTaskByUUIDAndPublicKey(ctx.Copy(), proofParameter.UUID, pk)
Expand Down
4 changes: 2 additions & 2 deletions coordinator/test/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -291,12 +291,12 @@ func testOutdatedProverVersion(t *testing.T) {
expectedErr := fmt.Errorf("check the login parameter failure: incompatible prover version. please upgrade your prover, minimum allowed version: %s, actual version: %s", minProverVersion, chunkProver.proverVersion)
code, errMsg := chunkProver.tryGetProverTask(t, message.ProofTypeChunk)
assert.Equal(t, types.ErrJWTCommonErr, code)
assert.Equal(t, expectedErr, fmt.Errorf(errMsg))
assert.Equal(t, expectedErr, errors.New(errMsg))

expectedErr = fmt.Errorf("check the login parameter failure: incompatible prover version. please upgrade your prover, minimum allowed version: %s, actual version: %s", minProverVersion, batchProver.proverVersion)
code, errMsg = batchProver.tryGetProverTask(t, message.ProofTypeBatch)
assert.Equal(t, types.ErrJWTCommonErr, code)
assert.Equal(t, expectedErr, fmt.Errorf(errMsg))
assert.Equal(t, expectedErr, errors.New(errMsg))
}

func testValidProof(t *testing.T) {
Expand Down

0 comments on commit 38f926b

Please sign in to comment.