Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup-relayer & gas-oracle): graceful restart #1076

Merged
merged 44 commits into from
Jan 25, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jan 14, 2024

Purpose or design rationale of this PR

Doc: https://www.notion.so/scrollzkp/Graceful-restart-of-rollup-relayer-and-gas-oracle-cf194c09c06c44f7a2215f7d4a36a4d8

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo added enhancement New feature or request bump-version Bump the version tag for deployment labels Jan 14, 2024
@colinlyguo colinlyguo self-assigned this Jan 14, 2024
@colinlyguo colinlyguo marked this pull request as ready for review January 15, 2024 03:29
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

Comparison is base (7e958d6) 56.49% compared to head (a900fae) 57.03%.
Report is 2 commits behind head on develop.

Files Patch % Lines
rollup/internal/controller/sender/sender.go 59.18% 40 Missing and 20 partials ⚠️
rollup/internal/controller/relayer/l2_relayer.go 57.14% 26 Missing and 1 partial ⚠️
rollup/internal/orm/pending_transaction.go 68.60% 18 Missing and 9 partials ⚠️
rollup/internal/controller/relayer/l1_relayer.go 78.26% 4 Missing and 1 partial ⚠️
common/types/db.go 96.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1076      +/-   ##
===========================================
+ Coverage    56.49%   57.03%   +0.54%     
===========================================
  Files          149      150       +1     
  Lines        11114    11161      +47     
===========================================
+ Hits          6279     6366      +87     
+ Misses        4406     4351      -55     
- Partials       429      444      +15     
Flag Coverage Δ
common 59.56% <96.66%> (+4.53%) ⬆️
coordinator 18.91% <ø> (ø)
database 42.85% <ø> (ø)
rollup 65.94% <69.40%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo force-pushed the feat-rollup-relayer-gas-oracle-graceful-restart branch from 3496906 to c9fbabe Compare January 15, 2024 04:07
@colinlyguo colinlyguo force-pushed the feat-rollup-relayer-gas-oracle-graceful-restart branch from 45d17e9 to 88de67b Compare January 15, 2024 16:30
@colinlyguo colinlyguo requested a review from zimpha January 16, 2024 10:30
@colinlyguo
Copy link
Member Author

colinlyguo commented Jan 22, 2024

TODOs after merging this PR:

  • sepolia: db migrate up and redeployment.
  • sepolia: testing graceful restart.
  • sepolia: checking db info correctness and CPU usage.
  • grafana: reconfigured metrics.
  • mainnet: db migrate up and redeployment.

@colinlyguo colinlyguo merged commit bab1841 into develop Jan 25, 2024
21 checks passed
@colinlyguo colinlyguo deleted the feat-rollup-relayer-gas-oracle-graceful-restart branch January 25, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants