Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sender): add access list to save gas #1077

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jan 15, 2024

Purpose or design rationale of this PR

Related EIP: https://eips.ethereum.org/EIPS/eip-2930

Briefe analysis:

  1. 100 * numL1Messages + C gas in commitBatch.
  2. 100 * numL1Messages + C gas in finalizeBatchWithProof.
  3. 200 for setL1BaseFee and setL2BaseFee.

refs:
commitBatch: #659
finalizeBatchWithProof: https://github.com/scroll-tech/scroll/blob/v4.3.52/contracts/src/L1/rollup/ScrollChain.sol#L368

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo added enhancement New feature or request bump-version Bump the version tag for deployment labels Jan 15, 2024
@colinlyguo colinlyguo self-assigned this Jan 15, 2024
@colinlyguo colinlyguo force-pushed the feat-sender-add-access-list-support branch from 7608033 to 0468bdb Compare January 15, 2024 11:56
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (69224eb) 56.45% compared to head (e048129) 56.12%.

Files Patch % Lines
rollup/internal/controller/sender/estimategas.go 51.21% 15 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1077      +/-   ##
===========================================
- Coverage    56.45%   56.12%   -0.33%     
===========================================
  Files          149      145       -4     
  Lines        11087    11048      -39     
===========================================
- Hits          6259     6201      -58     
- Misses        4406     4420      +14     
- Partials       422      427       +5     
Flag Coverage Δ
rollup 65.97% <56.52%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mmjahanara mmjahanara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colinlyguo colinlyguo merged commit 352aea4 into develop Jan 17, 2024
11 of 12 checks passed
@colinlyguo colinlyguo deleted the feat-sender-add-access-list-support branch January 17, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants